Reviews · yncyrydybyl/test_the_tests/2

Reviewers State Upstream

yncyrydybyl/test_the_tests/2 · 1 UPDATED 1329943293

just testing the tests on gitreview.com

tav cordoval ✗ diff

Comments

cordoval wrote a comment 1329943293

reda

yncyrydybyl rejected the submission 1284148021

yncyrydybyl approved safe to build 1284147665

yncyrydybyl wrote a comment 1284147658

looks stupid but lets give it a try

Builds

ID Platform Status When By

61001 osx 10.5 386
✓ init ✓ py-tests ✓ go-tests ✓ js-tests
1284147702 slave 3001

60001 linux amd64
✓ init ✓ py-tests ✗ go-tests ✓ js-tests
1284147691 slave 1

Changes



 		if err != nil {
 			return 1
 		}
-		for _, line := range strings.Split(output, "\n", -1) {
+		for _, line := range strings.Split(output, "\n", 0) {
 			if strings.HasPrefix(line, "processor") {
 				count += 1
 			}

src/amp/runtime/runtime.go
...	...	@@ -85,7 +85,7 @@ func GetCPUCount() (count int) {
85	85	if err != nil {
86	86	return 1
87	87	}
88		- for _, line := range strings.Split(output, "\n", -1) {
	88	+ for _, line := range strings.Split(output, "\n", 0) {
89	89	if strings.HasPrefix(line, "processor") {
90	90	count += 1
91	91	}

	Reviewers	State	Upstream
yncyrydybyl/test_the_tests/2 · 1 UPDATED 1329943293 just testing the tests on gitreview.com	tav cordoval	✗	diff